IntColumn Stats Diff #279
Merged
IntColumn Stats Diff #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grant-eden
requested review from
AnhTruong,
ChrisWallace2020,
JGSweets and
lettergram
as code owners
JGSweets
reviewed
Jun 23, 2021
grant-eden
commented
Jun 23, 2021
| @@ -247,7 +247,7 @@ def _add_helper(self, other1, other2): | |||
| if "num_negatives" in self.__calculations.keys(): | |||
| self.num_negatives = other1.num_negatives + other2.num_negatives | |||
|
|
|||
| def _diff_helper(self, other_profile): | |||
| def diff(self, other_profile, options=None): | |||
There was a problem hiding this comment.
ultimately renamed so the int column can just inherit this function instead of the int column creating its own. No reason for it to be private either.
There was a problem hiding this comment.
And allowing options for future use.
JGSweets
approved these changes
Jun 24, 2021
ChrisWallace2020
approved these changes
Jun 24, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
* Welcome to the best commit you've ever seen * This is almost ready. The code is still cooking * Some NICE code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only stats int has are numerical stats, so the difference function is pretty small