Ability to internally store counts of each category in a CategoricalColumn #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_profile.py and test cases for categorical_column_profile.py that checks that categories is counted properly
az85252
requested review from
AnhTruong,
ChrisWallace2020,
grant-eden,
JGSweets and
lettergram
as code owners
Closed
JGSweets
reviewed
Jun 28, 2021
|
|
||
| self._categories = utils._combine_unique_sets( | ||
| self._categories, df_series) | ||
| self._categories.update(df_series.value_counts(dropna = False).to_dict()) |
There was a problem hiding this comment.
no spaces around the = here dropna=False
JGSweets
reviewed
Jun 28, 2021
JGSweets
reviewed
Jun 28, 2021
Comment on lines
168
to
174
|
|
||
| def dict_of_categories(self): | ||
| """ | ||
| Returns the dict of categories with the number of occurrences | ||
| for each category. | ||
| """ | ||
| return dict(self._categories.items()) |
There was a problem hiding this comment.
Instead of dict_of_categories, we could do a functional property category_counts and return a copy of the dict.
However, I suggest adding that to the subsequent PR which adds it to the profile.
There was a problem hiding this comment.
For now we can just remove this function.
JGSweets
reviewed
Jun 28, 2021
dataprofiler/tests/profilers/test_categorical_column_profile.py
Outdated
Show resolved
Hide resolved
…rofile internally.
auto-merge was automatically disabled
June 28, 2021 21:08
Head branch was pushed to by a user without write access
grant-eden
approved these changes
Jun 28, 2021
JGSweets
approved these changes
Jun 28, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
…olumn (capitalone#296) * added function to store counts of each category for categorical_column_profile.py and test cases for categorical_column_profile.py that checks that categories is counted properly * fixed grammer for categorical_column_profile.py * added test case to validate count is correct for categorical column profile internally. * removed unused function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have allowed the system to track the counts of each category rather than just a list. Like, instead of just listing the categories like [a,b,c], we can now internally have a way to count each category. The categories will return as before like [a,b,c], but inside, _categories variable is now something like [a:1,b:2,c:3].