Add diff for FloatColumn #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-yin
requested review from
AnhTruong,
ChrisWallace2020,
grant-eden,
JGSweets and
lettergram
as code owners
JGSweets
reviewed
Jun 29, 2021
auto-merge was automatically disabled
June 29, 2021 22:06
Head branch was pushed to by a user without write access
grant-eden
reviewed
Jun 29, 2021
| :return: the FloatColumn differences | ||
| :rtype: dict | ||
| """ | ||
| differences = super().diff(other_profile, options=None) |
There was a problem hiding this comment.
I'm adding a general diff in the base column class so I think you will need to be specific that this is the Numerical Stats super.
There was a problem hiding this comment.
otherwise looks good to me
grant-eden
previously approved these changes
Jun 30, 2021
grant-eden
approved these changes
Jun 30, 2021
AnhTruong
approved these changes
Jun 30, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
* Add tests * Add precision to diff * Add specificity to diff parent method call * Simplified test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FloatColumn inherits diff() from NumericalStatsMixin, so all there is to do is test to ensure this inheritance behaves properly.