Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh pages update: add options for the top common words and characters to the text profiler #316

Merged
merged 7 commits into from
Jul 13, 2021

Conversation

AnhTruong
Copy link
Contributor

@AnhTruong AnhTruong commented Jul 8, 2021

Add two new option to text profile:

  • top_k_chars : top common characters
  • top_k_words : top common words

@JGSweets JGSweets enabled auto-merge (squash) July 9, 2021 19:44
Copy link
Contributor

@grant-eden grant-eden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissing my Review

@@ -464,12 +464,14 @@ Below is an breakdown of all the options.

* is_case_sensitive - (Boolean)
* stop_words - (List of Strings)
* top_k_chars - (Int) Apply to the output of vocab count when profiling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these descriptions are a little vague, can this be improved? Also, unrelated, can you add descriptions for the 2 options above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added, @gme5078

@JGSweets JGSweets merged commit 12b8859 into capitalone:gh-pages Jul 13, 2021
JGSweets pushed a commit that referenced this pull request Oct 5, 2022
…to the text profiler (#316)

* add vocab count to doc

* add option for top common words and characters

* add descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants