Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to have non-str in pandas passed to Labeler #343

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Allow user to have non-str in pandas passed to Labeler #343

merged 2 commits into from
Jul 19, 2021

Conversation

JGSweets
Copy link
Contributor

Currently, the structured labeler can only accept datasets which have been converted to string prior to entering the labeler. This PR resolves that issue by converting it internally for evaluation.

import pandas as pd

import dataprofiler as dp

# previously not possible because it could not take in non-str dataframes
labeler = dp.DataLabeler(labeler_type='structured')
preds = labeler.predict(pd.DataFrame([1, 22, 3, 4]))

@JGSweets JGSweets added Bug Something isn't working High Priority Dramatic improvement, inaccurate calculation(s) or bug / feature making the library unusable labels Jul 19, 2021
grant-eden
grant-eden previously approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@grant-eden grant-eden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AnhTruong
AnhTruong previously approved these changes Jul 19, 2021
View reviewed changes
@JGSweets JGSweets dismissed stale reviews from AnhTruong and grant-eden via b83f0e2 July 19, 2021 19:24
@AnhTruong AnhTruong enabled auto-merge (squash) July 19, 2021 19:28
@AnhTruong AnhTruong merged commit 2eb1848 into capitalone:main Jul 19, 2021
stevensecreti pushed a commit to stevensecreti/DataProfiler that referenced this pull request Jun 15, 2022
@JGSweets
Allow user to have non-str in pandas passed to Labeler (capitalone#343)
7127737 
* fix: allow user to have non-str in pandas passed to Labeler

* fix: naming to be sample as not necessarily string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnhTruong AnhTruong AnhTruong approved these changes

@grant-eden grant-eden grant-eden approved these changes

@ChrisWallace2020 ChrisWallace2020 Awaiting requested review from ChrisWallace2020

@lettergram lettergram Awaiting requested review from lettergram

Assignees

@AnhTruong AnhTruong

Labels
Bug Something isn't working High Priority Dramatic improvement, inaccurate calculation(s) or bug / feature making the library unusable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JGSweets @AnhTruong @grant-eden