Reformatted Tests for CSV Data Reader #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautomdas
requested review from
AnhTruong,
ChrisWallace2020,
grant-eden,
JGSweets and
lettergram
as code owners
JGSweets
reviewed
Jul 20, 2021
JGSweets
reviewed
Jul 20, 2021
JGSweets
reviewed
Jul 20, 2021
JGSweets
reviewed
Jul 20, 2021
JGSweets
reviewed
Jul 20, 2021
JGSweets
reviewed
Jul 20, 2021
JGSweets
previously requested changes
Jul 20, 2021
JGSweets
reviewed
Jul 20, 2021
JGSweets
dismissed
their stale review
fixed issue with tests not including buffer list
JGSweets
approved these changes
Jul 20, 2021
ChrisWallace2020
approved these changes
Jul 20, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
* Added CSVData tests for io streams * Change Data to CSVData * Fixed parameter issue and checked tests * Added change to fix 3.6 bug * Made small changes * Reformated CSV Tests * Added changes * Added seek default and buffer lists * Fixed comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundancy of opening streams everything in the original tests and consolidated the code for opening streams into the setUp class.