Top Profiler Structured Diff #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grant-eden
requested review from
AnhTruong,
ChrisWallace2020,
JGSweets and
lettergram
as code owners
|
Work in progress because I'm going to abstract it to the base profiler |
|
And I need type instance checking |
|
Ready for review! |
JGSweets
reviewed
Jul 26, 2021
JGSweets
added
High Priority
JGSweets
reviewed
Jul 26, 2021
Comment on lines
+1371
to
+1373
| for i in range(len(self._profile)): | ||
| col_name = self._profile[i].name | ||
| self_profile_schema[col_name].append(i) |
There was a problem hiding this comment.
how often are we doing this? should we have a util function to build this dict?
JGSweets
reviewed
Jul 26, 2021
JGSweets
reviewed
Jul 26, 2021
JGSweets
approved these changes
Jul 27, 2021
lettergram
approved these changes
Jul 27, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
* Profile diff * Updated * Undid small change * new line * Abstracted a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structured Profile Diff and Structured Col Profile Diff in one PR because its easier to review.
Let me know if I mocked too much.