Allow internal data function calls directly from our data class #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGSweets
requested review from
AnhTruong,
ChrisWallace2020 and
grant-eden
as code owners
JGSweets
added
Low Priority
AnhTruong
reviewed
Jul 26, 2021
JGSweets
force-pushed
the
allow-data-methods
branch
from
0c07e0a to
c57e155
Compare
grant-eden
reviewed
Jul 27, 2021
| class_name = self.__class__.__name__ | ||
| data_class_name = self.data.__class__.__name__ | ||
| if (not f"'{class_name}' object has no attribute '{name}'" | ||
| == str(attr_error)): |
There was a problem hiding this comment.
Its seems strange to use error string for the conditional, but I'm not sure any other way to do this check
There was a problem hiding this comment.
i validate it is an attribute error with the except and then validate the string, there might be a better way.
grant-eden
reviewed
Jul 27, 2021
|
|
||
| # validate will auto call the data function if it doesn't exist in | ||
| # BaseData | ||
| self.assertEqual("success", data.func1()) |
There was a problem hiding this comment.
personally, did you try this with csv/pandas functions?
grant-eden
approved these changes
Jul 27, 2021
AnhTruong
approved these changes
Jul 27, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
…talone#360) * feat: allow internal data function calls directly from our data class * fix: error raise comment and pep8 fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to directly access functions of the wrapped data inside of our data class. e.g. if the data internally is a pandas dataframe: