StringIO/BytesIO works for text data #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautomdas
requested review from
AnhTruong,
ChrisWallace2020,
grant-eden,
JGSweets and
lettergram
as code owners
JGSweets
reviewed
Jul 27, 2021
| @@ -25,27 +26,56 @@ def setUpClass(cls): | |||
| ] | |||
| cls.output_file_path = None | |||
|
|
|||
| cls.buffer_list = [] | |||
There was a problem hiding this comment.
i have one concern, are any of the above not utf-8 / ascii?
There was a problem hiding this comment.
Maybe should be in a follow-up PR to fix as I can see this having issues if encoding is not detected and appropriately selected.
JGSweets
previously approved these changes
Jul 27, 2021
|
|
||
| def test_is_match(self): | ||
| """ | ||
| Determine if the json file can be automatically identified from |
There was a problem hiding this comment.
This says "json" I'm guessing this was a copy paste error
auto-merge was automatically disabled
July 28, 2021 15:04
Head branch was pushed to by a user without write access
JGSweets
approved these changes
Jul 28, 2021
ChrisWallace2020
approved these changes
Jul 28, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
* StringIO/BytesIO works for text data * Changed comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for testing StringIO/BytesIO for TextData class