Bug fix to handle final word in word level argmax #426
+43
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lettergram
added
Bug
lettergram
requested review from
ChrisWallace2020 and
grant-eden
as code owners
ksneab7
previously approved these changes
Oct 28, 2021
JGSweets
reviewed
Oct 28, 2021
AnhTruong
reviewed
Oct 30, 2021
cbbruss
reviewed
Nov 3, 2021
| @@ -825,8 +825,8 @@ def _word_level_argmax(self, data, predictions, label_mapping, | |||
| label_count = {label_mapping[default_label]: 0} | |||
| for idx in range(len(sample)): | |||
There was a problem hiding this comment.
agreed, but not going to block the PR if @lettergram doesn't get to it prior to merge
JGSweets
approved these changes
Nov 10, 2021
ksneab7
approved these changes
Nov 10, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
* Update CODEOWNERS * Update data_processing.py * Update data_processing.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.