Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow generators to use reports without correlation matrices #289

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Allow generators to use reports without correlation matrices #289

merged 4 commits into from
Jul 11, 2023

Conversation

JGSweets
Copy link
Contributor

@JGSweets JGSweets commented Jul 7, 2023 •
edited
Loading

This adds:

  • Ability to make reports from non-correlated data.
  • new tests for Generators with non-correleated data
  • updated examples.
  • updates test workflow to include cov

@JGSweets JGSweets added the enhancement New feature or request label Jul 7, 2023
JGSweets
JGSweets commented Jul 10, 2023
View reviewed changes
examples/generate_from_report.ipynb
@@ -16,9 +16,10 @@
"The steps are:\n",
"1. Generate a profile report with the Real Dataset\n",
" - enable the correlation matrix and disable any unnecessary calcs\n",
"2. Map the report into `synthetic_data.make_data_from_report` to generate the Synthetic Dataset\n",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated this to use the generators

JGSweets
JGSweets commented Jul 10, 2023
View reviewed changes
examples/replicate_null_demo.ipynb
@@ -10,25 +10,187 @@
},
{
"cell_type": "code",
"execution_count": null,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated this to use the generators

JGSweets
JGSweets commented Jul 10, 2023
View reviewed changes
setup.cfg
@@ -0,0 +1,5 @@
# setup.cfg
[tool:pytest]
addopts = --cov synthetic_data --cov-report term-missing
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shows cov on run now.

@ssharpe42 ssharpe42 merged commit 428d284 into capitalone:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorfturner taylorfturner taylorfturner approved these changes

@ssharpe42 ssharpe42 ssharpe42 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JGSweets @ssharpe42 @taylorfturner