Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

int generator and test #293

Merged
merged 11 commits into from
Jul 12, 2023
Merged

int generator and test #293

merged 11 commits into from
Jul 12, 2023

Conversation

drahc1R
Copy link
Contributor

@drahc1R drahc1R commented Jul 10, 2023 •
edited
Loading

adding:

  • Random integer generator class
  • Integration tests between tabular dataprofile and random int generator

@drahc1R drahc1R changed the title [WIP] int generator and test int generator and test Jul 11, 2023
@taylorfturner taylorfturner enabled auto-merge July 11, 2023 14:21
@taylorfturner taylorfturner disabled auto-merge July 11, 2023 14:21
@drahc1R drahc1R changed the base branch from main to feature/simple-tabular-generator July 11, 2023 15:57
@taylorfturner taylorfturner self-requested a review July 11, 2023 16:19
taylorfturner
taylorfturner reviewed Jul 11, 2023
View reviewed changes
synthetic_data/distinct_generators/int_generator.py Outdated Show resolved Hide resolved
tests/test_int_generator.py Outdated Show resolved Hide resolved
synthetic_data/distinct_generators/int_generator.py Outdated Show resolved Hide resolved
@JGSweets JGSweets enabled auto-merge (squash) July 11, 2023 19:46
auto-merge was automatically disabled July 12, 2023 17:13

Head branch was pushed to by a user without write access

@JGSweets JGSweets enabled auto-merge (squash) July 12, 2023 19:06
JGSweets
JGSweets reviewed Jul 12, 2023
View reviewed changes
tests/test_int_generator.py Outdated
result = random_integers(self.rng, range[0], range[1])
for x in result:
self.assertGreaterEqual(x, range[0])
self.assertLessEqual(x, range[1])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eof line here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

taylorfturner
taylorfturner reviewed Jul 12, 2023
View reviewed changes
synthetic_data/distinct_generators/int_generator.py Outdated

:return: np array of integers
"""
return rng.integers(min_value, max_value, (num_rows,))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line EOF

tests/test_int_generator.py Outdated
result = random_integers(self.rng, range[0], range[1])
for x in result:
self.assertGreaterEqual(x, range[0])
self.assertLessEqual(x, range[1])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

auto-merge was automatically disabled July 12, 2023 19:32

Head branch was pushed to by a user without write access

@taylorfturner taylorfturner enabled auto-merge July 12, 2023 19:33
taylorfturner
taylorfturner suggested changes Jul 12, 2023
View reviewed changes
tests/test_int_generator.py Outdated Show resolved Hide resolved
auto-merge was automatically disabled July 12, 2023 19:39

Head branch was pushed to by a user without write access

@taylorfturner taylorfturner enabled auto-merge July 12, 2023 20:06
auto-merge was automatically disabled July 12, 2023 20:33

Head branch was pushed to by a user without write access

@JGSweets JGSweets enabled auto-merge (squash) July 12, 2023 20:35
auto-merge was automatically disabled July 12, 2023 20:35

Head branch was pushed to by a user without write access

@taylorfturner taylorfturner enabled auto-merge July 12, 2023 20:36
@taylorfturner taylorfturner merged commit 60ed0ae into capitalone:feature/simple-tabular-generator Jul 12, 2023
@JGSweets JGSweets mentioned this pull request Jul 12, 2023
Merged
drahc1R pushed a commit to drahc1R/synthetic-data that referenced this pull request Jul 27, 2023
@taylorfturner
Merge pull request capitalone#293 from drahc1R/int_generator
86ef3a3 
int generator and test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorfturner taylorfturner taylorfturner approved these changes

@JGSweets JGSweets JGSweets approved these changes

Assignees

@drahc1R drahc1R

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drahc1R @JGSweets @taylorfturner