Skip to content

more 'let else' simplification #1257

more 'let else' simplification

more 'let else' simplification #1257

Triggered via push September 2, 2024 15:14
Status Success
Total duration 6m 20s
Artifacts

ci.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
type parameter `T` goes unused in function definition: target/debug/build/fill_random_values-2fa3a13eb53b13ba/out/fill_capnp.rs#L2431
warning: type parameter `T` goes unused in function definition --> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/fill_random_values-2fa3a13eb53b13ba/out/fill_capnp.rs:2431:28 | 2431 | pub fn get_field_types<T>(index: u16) -> ::capnp::introspect::Type where T: ::capnp::traits::Owned { | ^ | = help: consider removing the parameter = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
type parameter `T` goes unused in function definition: target/debug/build/fill_random_values-2fa3a13eb53b13ba/out/fill_capnp.rs#L2434
warning: type parameter `T` goes unused in function definition --> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/fill_random_values-2fa3a13eb53b13ba/out/fill_capnp.rs:2434:33 | 2434 | pub fn get_annotation_types<T>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where T: ::capnp::traits::Owned { | ^ | = help: consider removing the parameter = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
useless use of `vec!`: capnp/src/serialize.rs#L1015
warning: useless use of `vec!` --> capnp/src/serialize.rs:1015:24 | 1015 | let segments = vec![ | ________________________^ 1016 | | vec![123, 0, 0, 0, 0, 0, 0, 0], 1017 | | vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0], 1018 | | ]; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[warn(clippy::useless_vec)]` on by default help: you can use an array directly | 1015 ~ let segments = [vec![123, 0, 0, 0, 0, 0, 0, 0], 1016 ~ vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0]]; |
useless use of `vec!`: capnp/src/serialize.rs#L1047
warning: useless use of `vec!` --> capnp/src/serialize.rs:1047:24 | 1047 | let segments = vec![ | ________________________^ 1048 | | vec![1, 0, 0, 0, 0, 0, 0, 0], 1049 | | vec![2, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0], 1050 | | ]; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec help: you can use an array directly | 1047 ~ let segments = [vec![1, 0, 0, 0, 0, 0, 0, 0], 1048 ~ vec![2, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0]]; |
this match could be replaced by its body itself: target/debug/build/capnp-rpc-test-7aa99e2ff50a0c3a/out/test_capnp.rs#L6419
warning: this match could be replaced by its body itself --> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnp-rpc-test-7aa99e2ff50a0c3a/out/test_capnp.rs:6419:7 | 6419 | / match method_id { 6420 | | _ => { ::capnp::capability::Promise::err(::capnp::Error::unimplemented("Method not implemented.".to_string())) } 6421 | | } | |_______^ help: consider using the match body instead: `::capnp::capability::Promise::err(::capnp::Error::unimplemented("Method not implemented.".to_string()))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding = note: `#[warn(clippy::match_single_binding)]` on by default
this match could be replaced by its body itself: target/debug/build/capnp-rpc-test-7aa99e2ff50a0c3a/out/test_capnp.rs#L9804
warning: this match could be replaced by its body itself --> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnp-rpc-test-7aa99e2ff50a0c3a/out/test_capnp.rs:9804:7 | 9804 | / match method_id { 9805 | | _ => { ::capnp::capability::Promise::err(::capnp::Error::unimplemented("Method not implemented.".to_string())) } 9806 | | } | |_______^ help: consider using the match body instead: `::capnp::capability::Promise::err(::capnp::Error::unimplemented("Method not implemented.".to_string()))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
this match could be replaced by its body itself: target/debug/build/capnp-rpc-test-7aa99e2ff50a0c3a/out/test_capnp.rs#L15723
warning: this match could be replaced by its body itself --> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnp-rpc-test-7aa99e2ff50a0c3a/out/test_capnp.rs:15723:9 | 15723 | / match method_id { 15724 | | _ => { ::capnp::capability::Promise::err(::capnp::Error::unimplemented("Method not implemented.".to_string())) } 15725 | | } | |_________^ help: consider using the match body instead: `::capnp::capability::Promise::err(::capnp::Error::unimplemented("Method not implemented.".to_string()))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
type parameters go unused in function definition: Foo, Bar: target/debug/build/capnpc-test-edition-2021-b95698048b5171e9/out/test_capnp.rs#L19583
warning: type parameters go unused in function definition: Foo, Bar --> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnpc-test-edition-2021-b95698048b5171e9/out/test_capnp.rs:19583:33 | 19583 | pub fn get_annotation_types<Foo,Bar>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where Foo: ::capnp::traits::O... | ^^^ ^^^ | = help: consider removing the parameters = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
type parameters go unused in function definition: Foo, Bar: target/debug/build/capnpc-test-edition-2021-b95698048b5171e9/out/test_capnp.rs#L19854
warning: type parameters go unused in function definition: Foo, Bar --> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnpc-test-edition-2021-b95698048b5171e9/out/test_capnp.rs:19854:35 | 19854 | pub fn get_annotation_types<Foo,Bar>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where Foo: ::capnp::traits:... | ^^^ ^^^ | = help: consider removing the parameters = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
type parameters go unused in function definition: Foo, Bar, Baz: target/debug/build/capnpc-test-edition-2021-b95698048b5171e9/out/test_capnp.rs#L20226
warning: type parameters go unused in function definition: Foo, Bar, Baz --> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnpc-test-edition-2021-b95698048b5171e9/out/test_capnp.rs:20226:35 | 20226 | pub fn get_annotation_types<Foo,Bar,Baz>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where Foo: ::capnp::tra... | ^^^ ^^^ ^^^ | = help: consider removing the parameters = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters