Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 'FromStructReader' trait #337

Closed
wants to merge 1 commit into from
Closed

remove 'FromStructReader' trait #337

wants to merge 1 commit into from

Conversation

danieleades
Copy link
Contributor

@danieleades danieleades commented Nov 19, 2022 •
edited
Loading

FromStructReader is equivalent to From<StructReader>. The latter is preferred, since it lets you use the standard Rust From and Into machinery

@danieleades danieleades mentioned this pull request Nov 19, 2022
Open
7 tasks
@dwrensha dwrensha added the breaking change requires version bump label Nov 21, 2022
@danieleades danieleades marked this pull request as ready for review November 21, 2022 17:39
@dwrensha
Copy link
Member

Done in 0bfb8d7

@dwrensha dwrensha closed this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change requires version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieleades @dwrensha