-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use built-in 'Default' trait #340
Conversation
46ac3c6
to
18fcb55
Compare
18fcb55
to
4250070
Compare
i've updated this PR in light of the fact that the other breaking changes have been merged. |
4250070
to
fb61d42
Compare
fb61d42
to
b92b5b9
Compare
@dwrensha i've refreshed this PR, and deprecated the existing methods rather than removing them outright |
b92b5b9
to
868c67d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #340 +/- ##
==========================================
- Coverage 51.88% 51.82% -0.06%
==========================================
Files 69 69
Lines 34113 34116 +3
==========================================
- Hits 17698 17680 -18
- Misses 16415 16436 +21 ☔ View full report in Codecov by Sentry. |
@dwrensha is this still of interest? |
I added |
Default
trait for constructing structs with no argumentsnew
method for constructing structs with arguments