Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move internal/packed out of internal #256

Closed
zenhack opened this issue Jun 25, 2022 · 1 comment · Fixed by #258
Closed

Move internal/packed out of internal #256

zenhack opened this issue Jun 25, 2022 · 1 comment · Fixed by #258

Comments

@zenhack
Copy link
Contributor

zenhack commented Jun 25, 2022

I recently ran into a use case where I wanted to using packed encoding on just a bare segment -- with no message header. The exposed interfaces in the main package don't provide a way to do this, and the raw Pack()/Unpack() apis in the packed package are under internal. I think we should move that package out of internal; there's no reason I see why this should be private.

@lthibault
Copy link
Collaborator

Oh good! I ran into a similar case a while back (I wanted to reuse []byte buffers ... can't remember the details), and this has been in the back of my mind ever since. +1 from me.

zenhack added a commit to zenhack/go-capnp that referenced this issue Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants