Fix some breakage in the regen.sh script. #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried running this while working on something else, and hit two problems: * When gen.sh is called from regen.sh, it is called as ./gen.sh but relative to the working directory it should be ../gen.sh * regen.sh puts go.capnp.go in the main package, which breaks the build; in the past this was how the package was supposed to be organized, but 88fcc4a moved it, and apparently the script was never updated. gen.sh actually puts it in the right place, so we can just remove this.
Merged
zombiezen
approved these changes
Feb 17, 2021
lthibault
pushed a commit
that referenced
this pull request
Feb 22, 2021
I tried running this while working on something else, and hit two problems: * When gen.sh is called from regen.sh, it is called as ./gen.sh but relative to the working directory it should be ../gen.sh * regen.sh puts go.capnp.go in the main package, which breaks the build; in the past this was how the package was supposed to be organized, but 88fcc4a moved it, and apparently the script was never updated. gen.sh actually puts it in the right place, so we can just remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried running this while working on something else, and hit two
problems:
relative to the working directory it should be ../gen.sh
build; in the past this was how the package was supposed to be
organized, but 88fcc4a moved it,
and apparently the script was never updated. gen.sh actually
puts it in the right place, so we can just remove this.