Simplify how we determine whether to embargo #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than having recvCap deal with this directly, we now have a separate routine that just checks if a client is local, which we invoke higher up in the chain. This means we're not trying to figure this out based on the cap descriptor, which means (1) fewer cases, and (2), in the case of a cap descriptor that denotes a promise or answer, we will be able to recursively call this on the target -- whose original CapDescriptor may not be known. This introduces one minor functional change: ErrorClients are now treated as local. This means we'll set up embargos for them, which we don't *need* to do, but it shouldn't be a problem; calling methods on errors is not a case that is terribly sensitive to the extra round trip. We could try to rework ErrorClient to avoid this, but it doesn't seem worth the trouble.
2 tasks
lthibault
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having recvCap deal with this directly, we now have a separate
routine that just checks if a client is local, which we invoke higher up
in the chain.
This means we're not trying to figure this out based on the cap
descriptor, which means (1) fewer cases, and (2), in the case of
a cap descriptor that denotes a promise or answer, we will be able
to recursively call this on the target -- whose original CapDescriptor
may not be known.
This introduces one minor functional change: ErrorClients are now
treated as local. This means we'll set up embargos for them, which
we don't need to do, but it shouldn't be a problem; calling methods
on errors is not a case that is terribly sensitive to the extra round
trip. We could try to rework ErrorClient to avoid this, but it doesn't
seem worth the trouble.