Transport: don't require clearing the cap table. #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also changes the rpc subsystem to avoid clearing the cap table for sent answers, which makes things easier to work with.
lthibault
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the rpc subsystem to avoid clearing the cap table for
sent answers, which makes things easier to work with, per #216.
In particular, with this change #213 works as expected.
We could further clean things up by getting rid of
answer.resultCapTableand just usinganswer.results.Message().CapTableeverywhere. I have a patch locally that tries to do this, but it introduces a deadlock I haven't pinned down, so I'm submitting this without that for now.