Use the embed package to do less in mktemplates. #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update, went ahead and finished the job; mktemplates is gone. |
|
This looks promising 🙂 I'm going to be traveling next week, and will have limited availability, but I'll give this a thorough review when I get back. Feel free to merge if it's blocking you in the meantime. |
|
We should probably change this import to |
lthibault
requested changes
Apr 16, 2022
|
I am confused; I don't see an import statement at that link? |
Oh, strange. It's line 36: |
...with a bit more work we can probably get rid of the mktemplates command entirely, but this was low hanging fruit. Note that this also re-generates some of the .capnp.go files. The differences are I assume because I am using a new version of the capnp compiler than when these were last generated? It seems nothing changed except for the exact bytes of the schema; the actual generated *code* is the same. We really should have CI make sure these are correct somehow.
|
Rebased on top of master to fix the merge conflicts. That should also pull in the change in #227, which deals with that import. |
lthibault
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...with a bit more work we can probably get rid of the mktemplates
command entirely, but this was low hanging fruit.
Note that this also re-generates some of the .capnp.go files. The
differences are I assume because I am using a new version of the capnp
compiler than when these were last generated? It seems nothing changed
except for the exact bytes of the schema; the actual generated code
is the same. We really should have CI make sure these are correct somehow.