Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowcontrol.fixedLimiter: Swap in semaphore.Weighted. #238

Merged
merged 3 commits into from
May 9, 2022

Conversation

zenhack
Copy link
Contributor

@zenhack zenhack commented May 8, 2022

...sadly, this does not fix my deadlock, but even so, no need to re-implement this ourselves.

...sadly, this does not fix my deadlock, but even so, no need to
re-implement this ourselves.
Otherwise the constant gets treated as int, which overflows on 32-bit targets.
@lthibault
Copy link
Collaborator

I haven't seen this particular error message yet, but may share the same underlying cause as the race condition triggered by #232 ?

I'm okay to merge this if you're confident this isn't a new bug.

=== RUN   TestRecvDisembargo
Error:     level0_test.go:1982: conn error: <nil>
Error:     level0_test.go:1982: conn error: send return: %!w(<nil>)
Error:     level0_test.go:1982: conn error: <nil>
Error:     level0_test.go:1982: conn error: <nil>
Error:     level0_test.go:1982: conn error: send return: %!w(<nil>)
Error:     level0_test.go:1982: conn error: <nil>
Error:     level0_test.go:1982: conn error: send return: %!w(<nil>)
Error:     level0_test.go:1982: conn error: send return: %!w(<nil>)
Error:     level0_test.go:1982: conn error: rpc: incoming disembargo: answer ID 55 has not sent return
Error:     level1_test.go:761: don't know how to handle abort; skipping
Error:     level1_test.go:668: recvMessage(ctx, p2): rpc pipe: receive on closed pipe
--- FAIL: TestRecvDisembargo (0.01s)

@zenhack
Copy link
Contributor Author

zenhack commented May 9, 2022

That test doesn't use fixedLimiter, so I'm pretty confident. Merging.

@zenhack zenhack merged commit 9113e6f into capnproto:main May 9, 2022
@zenhack zenhack deleted the fixedLimiter-weighted branch May 9, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants