Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: don't wrap nil error with fmt.Errorf. #262

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Bugfix: don't wrap nil error with fmt.Errorf. #262

merged 1 commit into from
Jul 12, 2022

Conversation

lthibault
Copy link
Collaborator

This was suddenly causing a test to fail when working on #261. When err is nil, fmt.Errorf produces a non-nil error, which is then reported to the ErrorReporter.

@lthibault lthibault added the bug label Jul 12, 2022
@lthibault lthibault requested a review from zenhack July 12, 2022 22:23
@lthibault lthibault merged commit a16baf1 into main Jul 12, 2022
@lthibault lthibault deleted the bugfix/nil-err-wrap branch July 12, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenhack zenhack Awaiting requested review from zenhack

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lthibault