Bugfix/nil exc check fails #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenhack
approved these changes
Jul 23, 2022
|
Just curious: were you observing the effects of this somewhere, or did you just spot it in the code while working on something else? |
|
@zenhack Sorry for the late response (was traveling). I observed this while trying to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two error-handling bugs that were generating false positives. The first is a classic "gotcha" of using
fmt.Errorf's%wdirective; wrapping a nil error in this way will produce a non-nil error. The second is a classic "gotcha" regarding interfaces; passing a nil*Exceptionas as a parameter of typeerrorproduces a non-nilerrorinterface.