Get rid of the struct wrappers around list types. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to make this consistent with structs and capabilities. This introduces a helper script (./internal/gen/gen.go) to generate a lot of the boilerplate methods, since not embedding means that we don't just inherit these anymore. In the future, it may make sense to move more of the boilerplate into this script; there's a fair chunk of it beyond what this patch added.
lthibault
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to make this consistent with structs and capabilities.
This introduces a helper script (./internal/gen/gen.go) to generate a
lot of the boilerplate methods, since not embedding means that we don't
just inherit these anymore.
In the future, it may make sense to move more of the boilerplate into
this script; there's a fair chunk of it beyond what this patch added.