Add client methods to interfaceClient template #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenhack
suggested changes
Aug 5, 2022
There was a problem hiding this comment.
Re: other methods:
- IsSame() definitely makes sense.
- I feel ambivalent about State(); it's such a rarely used thing that having to cast to Client might actually be good to keep it out of the namespace for "normal" uses.
- I think WeakRef makes sense, but also I think we should make WeakClient a generic type (
type WeakClient[T ~ClientKind]) if we're going to do that (and also get rid of the pointer indirection like we did with Client. Probably enough stuff be a separate PR.
|
Agreed for |
zenhack
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Matrix, commonly-used
Clientmethods are not accessible from subtypes ofClient.This PR adds the following methods to the
interfaceClienttemplate:client.Stringclient.Resolveclient.SetFlowLimiterIt also adds docstrings to existing methods.
@zenhack What are your thoughts the other methods (
WeakRef,State,IsSame, ...)? I can't quite decide whether it makes sense to export these. Are they deliberately part of the public API, or are they intended for internal use, but originally exported out of necessity?