Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 271 #288

Merged
merged 7 commits into from
Aug 8, 2022
Merged

Fix 271 #288

merged 7 commits into from
Aug 8, 2022

Commits on Jul 28, 2022

  1. Configuration menu
    Copy the full SHA
    5e8dc8f View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. Fix deadlock subtest.

    lthibault committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    109a526 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Configuration menu
    Copy the full SHA
    3ffbf48 View commit details
    Browse the repository at this point in the history
  2. Fix bitrot in test.

    ...after merging in main, this no longer built, due to the change
    removing struct wrappers.
    zenhack committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    f0302c2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    37f97a0 View commit details
    Browse the repository at this point in the history
  4. Add missing lock acquisition.

    The callback is run without holding c.mu, so we need to acquire it to
    mutate the questions table.
    
    I have not (to my knowledge) observed symptoms of this, but spotted it
    while debugging something else.
    zenhack committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    8fcd7eb View commit details
    Browse the repository at this point in the history
  5. Fix capnproto#271

    Silly mistake: when a pipelined question failed to send, we were
    rejecting the promise for the *original* question, not the new one we
    just failed to send -- so when the return message for the original came
    back, we got a panic. Solution is to reject q2, not q.
    
    Note that the tests also needed tweaking, because we don't expect no
    error, we just don't want a panic -- the error should reflect the
    canceled context.
    zenhack committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    779b538 View commit details
    Browse the repository at this point in the history