Clarify a comment #331
Merged
Clarify a comment #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per capnproto#306, the call sites where this is unused struck me as suspicious -- but they are actually fine; sendCap already takes care of incrementing where necessary. The return value only needed by sendReturn, so that it can arrange to release these when it receives a finish message with releaseParamCaps = true. This patch clarifies the comment to make it clear that the caller is not responsible for actually applying the refcounts.
lthibault
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #306, the call sites where this is unused struck me as suspicious -- but they are actually fine; sendCap already takes care of incrementing where necessary.
The return value only needed by sendReturn, so that it can arrange to release these when it receives a finish message with releaseParamCaps = true.
This patch clarifies the comment to make it clear that the caller is not responsible for actually applying the refcounts.