Add benchmark for streaming calls. #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which seems to fix capnproto#344. This indicates there's a bug in transport.NewPipe(), but I kinda want to phase that out anyway, so...
|
Ack, just realized this doesn't really measure what I wanted it to; marking as a draft for the moment. |
zenhack
force-pushed
the
stream-bench
branch
from
8949924
to
f8581d9
Compare
|
It's hard to see how that failure could be related to adding a new benchmark, so I'm going to assume this was a pre-existing bug that is rare enough for it to have slipped by so far; I'll open an issue. |
lthibault
approved these changes
Nov 27, 2022
|
Ok, that's a different panic, opened #349 for it. Going to run again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this includes the fix from #345, which should be merged first.
As expected, the profile output has runtime.mallocgc at the top.