Add helpers Serve and ListenAndServe #355
Conversation
|
Just a quick thing: can you lowercase the file names? |
|
What is still missing is TLS support. I think that is a must for use in production. |
|
Quoting Henk (2022-11-29 21:24:50)
On that last note, I found that when passing context to ...
"ListenConfig).Listen(ctx, " ... it doesn't seem to respond to
cancelling the context. Not sure if there is a good reason for using
context here, other than as convention.
If there's no actual effect then I'd prefer just using net.Listen; keep
it simple.
|
After digging a bit deeper it is passed to a netFD.connect which does use it although how exactly I can't follow. I'm a bit concerned what happens if the context isn't closed after exit. ... since it isn't doing anything for our use-case lets stick to the regular listen. |
Indeed a good point. I'll expand the tests with using a bootstrap interface. |
Added a test that uses Serve to transfer data.
Change API to take bootstrap client instead of options Added testcase to verify proper method handling using Serve. Added verification of proper release of capabilities. Update documentation to explain the functions release bootstrap client.
hspaay
requested review from
lthibault and
zenhack
and removed request for
lthibault
Remove the goroutine for handling the incoming connection as rpc.NewConn already does this.
|
Test failure looks like #349. Re-running tests. |
First draft of a helper for Serve and ListenAndServe.
Using context for ListenAndServe as it is the only way to close it when needed.