Revert "Fix #301." #367
Merged
Revert "Fix #301." #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenhack
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
For posterity: this is the source of #349; the analysis in the (now removed) comment is correct insofar as it identifies what was causing a data race before, but doing it the other way panics, because when the finish message comes in the message will be freed, possibly before answerQueue.fulfill() is done with it, causing a panic.
My next task is to come up with a proper fix for both of these issues, but the consequences of the data race are less bad than the panic, and this is blocking @lthibault from releasing, so we're reverting this for the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a2ae8c4.