Conn: wrap fields protected by mu in struct. #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the comment, this makes it much easier to tell at a call site whether you need to be holding the lock. In the process of doing this, I also added comments on two methods where the need to hold the lock was not documented, and also pulled the `closed` channel out of this section -- it is not actually supposed to be protected by Conn.mu
lthibault
requested changes
Dec 13, 2022
lthibault
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the comment, this makes it much easier to tell at a call site whether you need to be holding the lock. In the process of doing this, I also added comments on two methods where the need to hold the lock was not documented, and also pulled the
closedchannel out of this section -- it is not actually supposed to be protected by Conn.mu