Fix #382 #391
Merged
Fix #382 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reworks the locking such that newPipelineCallMessage & newImportCallMessage expect the caller to already be holding the connection lock, and then removes the call to syncutil.Without in order to comply with sendMessage's contract. There is a big downside here: it means that it is no longer OK for PlaceArgs to call into the RPC subsystem, as it could cause a deadlock. We're planning on reworking this interface to get rid of PlaceArgs anyway (see capnproto#64), and this kind of code is not that common and generally easy to avoid, so in the interest of finishing out one batch of refactoring before starting the next, I am of the opinion that this is probably the right thing to do.
|
Failure looks like the same as in #376 (comment) |
lthibault
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the locking such that newPipelineCallMessage & newImportCallMessage expect the caller to already be holding the connection lock, and then removes the call to syncutil.Without in order to comply with sendMessage's contract.
There is a big downside here: it means that it is no longer OK for PlaceArgs to call into the RPC subsystem, as it could cause a deadlock.
We're planning on reworking this interface to get rid of PlaceArgs anyway (see #64), and this kind of code is not that common and generally easy to avoid, so in the interest of finishing out one batch of refactoring before starting the next, I am of the opinion that this is probably the right thing to do.
@lthibault, I want your opinion on the PlaceArgs thing.