Fix occasional spurious test failure. #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along the lines of 3fc5065, just with a different test: occasionally, with the race detector and other tests running in parallel, I will get a timeout here. But I think that's just that there's no reason in principle this can't take more than two seconds, so under extreme circumstances it may. So this patch removes the timeout; if there's a real bug the channel receive will just hang and eventually the test-suite-wide timeout will catch it.
|
...tacked on a second commit fixing a similar problem in another test. Note that the first of these I have seen in CI a few times. |
Let the test suite's timeout deal with it.
This is new, isn't it? ☝️ |
|
I re-ran the tests and they passed, so I went ahead and merged. |
|
Yeah, that is new -- pretty confident this isn't the source, but we should dig into that. |
Closed
|
I've opened #420 to track it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the lines of 3fc5065, just with a different test: occasionally, with the race detector and other tests running in parallel, I will get a timeout here. But I think that's just that there's no reason in principle this can't take more than two seconds, so under extreme circumstances it may. So this patch removes the timeout; if there's a real bug the channel receive will just hang and eventually the test-suite-wide timeout will catch it.