WIP: groundwork for request-based API #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...as discussed in capnproto#64. To avoid an extra copy we will have to rework ClientHook & possibly other low level APIs, but this will let us play with code generation and user-facing APIs.
lthibault
reviewed
Feb 19, 2023
lthibault
reviewed
Feb 24, 2023
|
If this is "done" for you, then it LGTM. Happy to re-review later if you want to add more, of course. |
|
It could probably at least use some docs before we merge this piece. |
lthibault
previously approved these changes
Feb 28, 2023
lthibault
previously approved these changes
Mar 1, 2023
|
Good question. My instinct is that we should return an error here
indicating the double-call, as that seems like it's almost certainly a
mistake.
Quoting Louis Thibault (2023-03-01 11:45:57)
… @lthibault approved this pull request.
Just a thought: what happens if I call Send() multiple times on the
same request? Do we want to make it idempotent?
|
|
Then again, it might be useful in cases where you want to repeatedly make the same call? I wouldn't want to support this if it makes implementation overly complex, of course. I'm also fine with the simple approach of documenting behavior, e.g. "Callers MUST NOT call Send more than once." |
|
That gets weird since we store the releasefunc and future -- would we have a slice of them? seems not worth it. Checking for a double-call is easy, so we may as well; I'll do that. |
|
SGTM. 👍 |
|
Done. |
lthibault
approved these changes
Mar 1, 2023
lthibault
requested changes
Mar 1, 2023
lthibault
requested changes
Mar 1, 2023
lthibault
approved these changes
Mar 1, 2023
Per Louis's request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as discussed in #64. To avoid an extra copy we will have to rework ClientHook & possibly other low level APIs, but this will let us play with code generation and user-facing APIs.