WIP: avoid deadlocks wrt. embargo #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(also structReturner)
This should head off some potential deadlocks. Still WIP though; see the FIXME comment in particular.
lthibault
previously approved these changes
Feb 20, 2023
Stared at this a bit; I don't think anything needs to be done, since Shutdown() shouldn't get called if there are outstanding calls.
The body of this was more verbose than it needed to be, and upon cutting it down I realized it could just be inlined, so here we go.
|
Ok, this is ready now. |
|
I have no idea what to make of this: https://github.com/capnproto/go-capnproto2/actions/runs/4259670598/jobs/7412098591#step:5:636 It looks like a compile error? I'm going to re-run, but that's bizzare either way. It definitely builds locally. |
lthibault
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
Marking this WIP because there are a few bits that are still a little dodgy, both stylistically and in terms of correctness. But the tests pass.