-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to buffer pool #466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things in-line
6e26f59
to
adde455
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor style nit
I ended up re-writing a significant portion of this to allow users to provide their own pool implementations. I think this can have a very large impact in niche cases (e.g. embedded systems), where you might want to tune the pooling behavior to save memory. I can also imagine applications that allocate a large volume of very big segments. I've also added tests around the sensitive parts of the default pool implementation. |
Weird, I'm getting build failures. Re-running 🤨 |
Ok fixed. Ready for review. |
d7c2b27
to
5d2e5c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments in-line
Ok, I think this is finally ready to merge. How do you feel about squashing this branch? |
Once we figure out CI, SGTM. |
cb761ce
to
907b4a0
Compare
range
instead of classicfor
loop)