Send promise resolution messages #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs testing.
lthibault
requested changes
Feb 28, 2023
zenhack
commented
Mar 1, 2023
|
Added a (failing) test. Stay tuned. |
Leaks a client; need to investigate.
lthibault
previously approved these changes
Mar 1, 2023
|
Test is fixed. |
|
Tacked on another commit to handle a remote peer that doesn't understand resolve messages; without this, we'd leak caps. |
zenhack
changed the title
...which hangs. Some debugging suggests that this *is* being removed from the table, but I need to figure out why the cap isn't actually released.
lthibault
reviewed
Mar 12, 2023
lthibault
previously approved these changes
Mar 12, 2023
|
Yeah, I need to figure out why that test is failing -- I did some debugging, and the export is definitely being popped from the table, so I'm not sure why Shutdown() isn't actually being called. I'll keep you posted. |
At some point in the past, Resolver was called Fulfiller; this is left over from that.
|
Alright, last commit fixes the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates sendCap such that it checks whether it should send senderHosted or senderPromise for an export. If the latter, it also arranges for a Resolve message to be sent when the promise is resolved.
Still TODO:
Note: this patch adds a helper method to marshal an
errorinto anException.