Drop pre go 1.18 implementation of Encoder.write #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and use it on all versions we support. Presumably the build tag was meant to avoid using this on *older* versions of Go, but it currently also prevents it being used on *newer* versions, which is not what we want. We already require at least Go 1.18 anyway for generics, so there's no need for conditional compilation here anymore.
lthibault
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and use it on all versions we support. Presumably the build tag was meant to avoid using this on older versions of Go, but it currently also prevents it being used on newer versions, which is not what we want. We already require at least Go 1.18 anyway for generics, so there's no need for conditional compilation here anymore.