Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move (de)coder to its own file #487

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Move (de)coder to its own file #487

merged 1 commit into from
Mar 23, 2023

Conversation

lthibault
Copy link
Collaborator

I thought I'd look into #482 for a bit, and see if I could pave the way for Piotr. Along the way, I thought it might make sense to split up message.go, as it's getting quite long.

This PR splits message.go into two files: message.go and codec.go, the latter containing Encoder and Decorder. Ditto for message_test.go

@lthibault lthibault requested a review from zenhack March 23, 2023 18:53
@lthibault lthibault self-assigned this Mar 23, 2023
@zenhack
Copy link
Contributor

zenhack commented Mar 23, 2023

Failure is #348; re-running.

@lthibault lthibault merged commit 3889a03 into main Mar 23, 2023
@lthibault lthibault deleted the cleanup/split-msg-and-codec branch March 23, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenhack zenhack zenhack approved these changes

Assignees

@lthibault lthibault

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lthibault @zenhack