Don't directly export cap table from message #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lthibault
force-pushed
the
prep/dont-export-msg-captable
branch
4 times, most recently
from
afbd61d
to
e2efc56
Compare
lthibault
force-pushed
the
prep/dont-export-msg-captable
branch
from
91a389a
to
da81dcf
Compare
zenhack
suggested changes
Apr 3, 2023
zenhack
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR paves the way for adding refcounting to
capnp.Message. Prior attempts to do so where frustrated by other packages accessingMessage.CapTabledirectly. This PR defines aMessage.CapTable()method, that returns a newCapTabletype. The cap table is accessed and updated through the latter's methods. This has the side benefit of simplifying code in quite a few places.Note that this PR ended up rather large, but that most of the changes involve updating calls to
Message.AddCapetc. The diff is actually quite simple beyond that. I recommend reviewing each PR separately, and focusing your attention onmessage.goandcaptable.go.