promiseState: remove obsolete ongoingCalls and callsStopped fields. #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch has no functional impact; we never actually do a receive on callsStopped. There is a now-removed receive on a local callsStopped variable, but it is never assigend -- it was obviously supposed to be at some point, but I believe we want to remove this anyway, since we are in general no longer blocking on calls before shutting down.
zenhack
force-pushed
the
delete-callsstopped
branch
from
44c08c3
to
f7e48e6
Compare
lthibault
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch has no functional impact; we never actually do a receive on
callsStopped. There is a now-removed receive on a local callsStopped
variable, but it is never assigend -- it was obviously supposed to be
at some point, but I believe we want to remove this anyway, since we are
in general no longer blocking on calls before shutting down.