Skip to content

Commit

Permalink
Disable the use of ninja for windows builds
Browse files Browse the repository at this point in the history
Aperantly github added ninja to all of there runners now. This
causes the windows build to fail. This is expected because we
add the architecture as a compiler arg which is not known to
ninja. Even with this the build fails.

This commit disables ninja on windows for now. Once we fixed the
underlying issue with ninja and windows we can reenable it.
  • Loading branch information
tobiasah authored and haata committed Oct 23, 2023
1 parent ca8d120 commit 7a49706
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion buildutils/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def build_libcapnp(bundle_dir, build_dir): # noqa: C901

# Enable ninja for compilation if available
build_type = []
if shutil.which("ninja"):
if shutil.which("ninja") and os.name != "nt":
build_type = ["-G", "Ninja"]

# Determine python shell architecture for Windows
Expand Down

0 comments on commit 7a49706

Please sign in to comment.