Fix retransmit bug for large messages causing message corruption #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic bug: We are looping over segments sent by the C++ library and sending them over a python transport. If the last message is larger than the transport pause threshold, this causes the transport to pause us. In that case, we forget to increment the current write_index, causing us to retransmit the same message in an infinite loop. This is a serious bug, because it causes messages to become corrupted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic bug: We are looping over segments sent by the C++ library and sending them over a python transport. If the last message is larger than the transport pause threshold, this causes the transport to pause us. In that case, we forget to increment the current write_index, causing us to retransmit the same message in an infinite loop.
This is a serious bug, because it causes messages to become corrupted.