Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicCapabilityClient: fix crash due to wrong types #341

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

lewinb-corp
Copy link
Contributor

In the last commit touching this line, a ')' was put in the wrong place, leading to errors like this one:

  File "capnp/lib/capnp.pyx", line 2172, in capnp.lib.capnp._DynamicCapabilityClient.__dir__
TypeError: unsupported operand type(s) for +: 'set' and 'tuple'

In the last commit touching this line, a ')' was put in the wrong place, leading to errors like this one:

```
  File "capnp/lib/capnp.pyx", line 2172, in capnp.lib.capnp._DynamicCapabilityClient.__dir__
TypeError: unsupported operand type(s) for +: 'set' and 'tuple'
```
@haata
Copy link
Collaborator

haata commented Oct 21, 2023

@tobiasah Can you take a look at the Windows failure. I suspect something changed in the GitHub Actions windows-2019 os target and is either setting a variable or a dependency is missing.

The way it's supposed to work is cmake is supposed to auto-detect that it's a windows environment and use that build system. But for some reason ninja is being chosen (which probably isn't installed).

@haata haata merged commit c9bea05 into capnproto:master Oct 23, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants