-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cpy to v9 and use ESM-compatible import #139
base: master
Are you sure you want to change the base?
Conversation
The snapshots that changed path are likely affected by the breaking change in cpy. |
Fixed and force-pushed |
codebuild while codebuild v 6.0 uses node16: https://github.com/aws/aws-codebuild-docker-images/blob/48b53e25cf36dcb1e0b124bc7bebfb342d161b91/ubuntu/standard/6.0/Dockerfile#L182 We use the default setting for liflig-cdk/src/cdk-pipelines/liflig-cdk-pipeline.ts Lines 183 to 186 in fe5809e
The |
@@ -4,6 +4,7 @@ | |||
"declaration": true, | |||
"target": "ES2018", | |||
"module": "commonjs", | |||
"moduleResolution": "Node16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code should still run in node12. But changing to codebuild 6.0 removes doubt
cpy changed from commonjs to esm in v9.
It also had a breaking change regarding
parent
option.