Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cpy to v9 and use ESM-compatible import #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

krissrex
Copy link
Contributor

@krissrex krissrex commented Jul 7, 2022

cpy changed from commonjs to esm in v9.
It also had a breaking change regarding parent option.

@krissrex krissrex requested a review from stekern July 7, 2022 11:21
@krissrex
Copy link
Contributor Author

krissrex commented Jul 7, 2022

The snapshots that changed path are likely affected by the breaking change in cpy.
An option might be needed, to not affect the snapshots

@krissrex
Copy link
Contributor Author

krissrex commented Jul 7, 2022

Fixed and force-pushed

@krissrex
Copy link
Contributor Author

krissrex commented Jul 21, 2022

codebuild aws/codebuild/standard:5.0 uses node12 and 14: https://github.com/aws/aws-codebuild-docker-images/blob/48b53e25cf36dcb1e0b124bc7bebfb342d161b91/ubuntu/standard/5.0/Dockerfile#L219-L229

while codebuild v 6.0 uses node16: https://github.com/aws/aws-codebuild-docker-images/blob/48b53e25cf36dcb1e0b124bc7bebfb342d161b91/ubuntu/standard/6.0/Dockerfile#L182


We use the default setting for codepipelines (CDK Pipelines), which is 5.0
image

this.cdkPipeline = new pipelines.CodePipeline(this, "CdkPipeline", {
synth,
codePipeline: this.codePipeline,
})

The 6_0 is not present as a default in CDK yet, but you can specify images using a name.

@@ -4,6 +4,7 @@
"declaration": true,
"target": "ES2018",
"module": "commonjs",
"moduleResolution": "Node16",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code should still run in node12. But changing to codebuild 6.0 removes doubt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant