Add circuit breakers to Fargate service #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adds better support for using circuit breakers with the fargate service to prevent boot-loops in ecs.
Description
This change adds an option for enabling circuit breakers for the Fargate service. In addition to enabling a feature flag which stops the service from being replaced when using enabling circuit breakers when no deployment controller was previously defined.
Testing
The circuit breaker is toggled on for the tests being added to the snapshots.
Audience
Looks to be both CargoNet and Tomler at the moment, but might be beneficial for more teams in the future in addition to enabling the circuit breakers by default to prevent bootloops.