Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The integration tests are flaky #1716

Closed
OlaviSau opened this issue Feb 1, 2025 · 2 comments
Closed

The integration tests are flaky #1716

OlaviSau opened this issue Feb 1, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@OlaviSau
Copy link
Contributor

OlaviSau commented Feb 1, 2025

Describe the bug
The integration tests fail quite often

To Reproduce
Steps to reproduce the behavior:
Run integration tests 10 times, more than half will fail.

Expected behavior
Integration tests do not fail more than 1% of the time.
@OlaviSau OlaviSau added the bug Something isn't working label Feb 1, 2025
OlaviSau added a commit to OlaviSau/happy-dom that referenced this issue Feb 1, 2025
@OlaviSau
fix: [capricorn86#1716] Fix integration test failing most of the time
d61dc39
capricorn86 pushed a commit that referenced this issue Feb 1, 2025
@OlaviSau
chore: [#1716] Fix integration test failing most of the time (#1717)
33e888d
@capricorn86
Copy link
Owner

capricorn86 commented Feb 7, 2025 •
edited
Loading

@OlaviSau can we close this for now and create a new ticket if a another fix is done? 🙂

@OlaviSau
Copy link
Contributor Author

@OlaviSau can we close this for now and create a new ticket if a another fix is done? 🙂

Yeap. It's a bit difficult to properly improve the integration tests as some of them use true globals. I'll create another issue when I have an idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OlaviSau @capricorn86