Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement childNodes and children as getters #960

Closed
edoardocavazza opened this issue Jul 2, 2023 · 1 comment
Closed

Implement childNodes and children as getters #960

edoardocavazza opened this issue Jul 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@edoardocavazza
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I am working to a DOM library that is using the childNodes prototype descriptor, but in the happy-dom environment it is missing since it is implemented as class field.

Describe the solution you'd like
Espose childNodes and children as getters, transforming read/write class fields to _childNodes and _children.

Describe alternatives you've considered
I don't know.

Additional context
I am going to open a PR with an implementation proposal.

@edoardocavazza edoardocavazza added the enhancement New feature or request label Jul 2, 2023
edoardocavazza added a commit to edoardocavazza/happy-dom that referenced this issue Jul 2, 2023
capricorn86 added a commit to edoardocavazza/happy-dom that referenced this issue Aug 22, 2023
capricorn86 added a commit to edoardocavazza/happy-dom that referenced this issue Aug 22, 2023
capricorn86 added a commit to edoardocavazza/happy-dom that referenced this issue Aug 22, 2023
capricorn86 added a commit to edoardocavazza/happy-dom that referenced this issue Aug 22, 2023
capricorn86 added a commit that referenced this issue Aug 22, 2023
#960@minor: Implement childNodes and children as getters.
@capricorn86
Copy link
Owner

Your fix has been released @edoardocavazza 🙂

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v10.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants