Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1067@major: Changes the default user agent. #1068

Merged
merged 1 commit into from
Sep 15, 2023
Merged

#1067@major: Changes the default user agent. #1068

merged 1 commit into from
Sep 15, 2023

Conversation

capricorn86
Copy link
Owner

No description provided.

@capricorn86 capricorn86 linked an issue Sep 15, 2023 that may be closed by this pull request
Fix problems with the userAgent implementation #1067
Closed
@capricorn86 capricorn86 merged commit 9c64001 into master Sep 15, 2023
@capricorn86 capricorn86 deleted the task/1067-fix-problems-with-the-useragent-implementation branch September 15, 2023 15:20
@mash-graz
Copy link
Contributor

The use of process.platformand process.arch in the UserAgent string construction will crash the Window() initialization when used in vite environments, because these entries are not available.

There is already a fix for this issue included in PR #1158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix problems with the userAgent implementation
2 participants
@capricorn86 @mash-graz