fix: [#1534] Fix click event not removing open attribute #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capricorn86
approved these changes
Nov 4, 2024
|
Thank you for your contribution @mikedidomizio! ⭐ Sorry that it took such a long time to get this in. I have added some unit tests and added some additional rules according to spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1534
I'm not exactly sure this is the correct approach to take as I'm not familiar with the project setup, but maybe we can figure it out.
This change makes it so that a click event on the
<details>element will trigger the removal or adding of theopenattribute.Before clicking on
<details>would not remove the attribute or add it either.